fix AsyncQueueSegmentDispatcher performance issue #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mark this on 2.3.0, as @liuhaoyang is planning to run 2.2.0 release, we should stop adding new things. |
lu-xiaoshuang
force-pushed
the
performance
branch
2 times, most recently
from
36dfc36
to
6b01726
Compare
lu-xiaoshuang
force-pushed
the
performance
branch
from
6b01726
to
5f6463a
Compare
|
Have there been any performance test results ? @lu-xiaoshuang |
New solution affords 30+k spans per second in normal scenarios (not pressure testing) with following configurations: QueueSize = 10000, BatchSize = 2000, Parallel = 5, Interval = 50, Reporter = kafka |
liuhaoyang
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a
multiple producers multiple consumers(MPMC) problem.TimerandConcurrentQueueshall be dropped.